Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
suggest parentheses around ‘&&’ within ‘||’
#1
Hi folks.

when I compile muse2,
i get these compiler warnings:

/home/wallee/hafi/Dokumente/prj/musik/muse/muse2-unstable/muse/master/lmaster.cpp: In member function ‘void LMaster::updateList()’:
/home/wallee/hafi/Dokumente/prj/musik/muse/muse2-unstable/muse/master/lmaster.cpp:296:78: warning: suggest parentheses around ‘&&’ within ‘||’
/home/wallee/hafi/Dokumente/prj/musik/muse/muse2-unstable/muse/master/lmaster.cpp:301:78: warning: suggest parentheses around ‘&&’ within ‘||’
/home/wallee/hafi/Dokumente/prj/musik/muse/muse2-unstable/muse/master/lmaster.cpp:307:78: warning: suggest parentheses around ‘&&’ within ‘||


======================== In my eyes theer should be added like here parantheses
if ( ( /*here*/ (ik != k->rend()) && (is == s->rend()) && (ik->second.tick >= it->second->tick) /*upto here*/ )
|| (/*here*/ (it == t->rend()) && (ik->second.tick >= is->second->tick ) /*upto here*/) ) {// ik biggest
insertKey(ik->second);
++ik;
}

Bye,
WillyFoobar <!-- sBig Grin --><img src="{SMILIES_PATH}/icon_e_biggrin.gif" alt="Big Grin" title="Very Happy" /><!-- sBig Grin -->
Reply
#2
Hi Willy,

and thank you, if that works I will change it tonight!
I tried before but couldn't get the compiler to stop complaining myself. <!-- s:oops: --><img src="{SMILIES_PATH}/icon_redface.gif" alt=":oops:" title="Embarrassed" /><!-- s:oops: -->

Regards,
Robert
Reply


Forum Jump:


Users browsing this thread: 1 Guest(s)